Conversation
Member
skerbis
commented
Oct 14, 2025
skerbis
commented
- Add ClassManager.php for complete class lifecycle management
- Extend NewInstallManager and UpdateManager with class support
- Add RepositoryManager method for class status checking
- Create unified upload interface with tab navigation
- Add classes.php page for class installation and updates
- Implement class installation to project/lib/gitClasses/ structure
- Add multilingual support for class management
- Create overview page with class management documentation
- Support for class.yml metadata and README files
- Classes installed with proper directory structure and autoloading support
- Add ClassManager.php for complete class lifecycle management - Extend NewInstallManager and UpdateManager with class support - Add RepositoryManager method for class status checking - Create unified upload interface with tab navigation - Add classes.php page for class installation and updates - Implement class installation to project/lib/gitClasses/ structure - Add multilingual support for class management - Create overview page with class management documentation - Support for class.yml metadata and README files - Classes installed with proper directory structure and autoloading support
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive PHP class management functionality to the GitHub Installer, enabling users to install, update, and upload PHP classes from/to GitHub repositories alongside existing module and template management.
- Implements ClassManager for complete class lifecycle management including installation, updates, and uploads
- Extends existing managers (NewInstallManager, UpdateManager, RepositoryManager) with class support
- Adds unified upload interface with tab navigation supporting modules, templates, and classes
- Creates standardized directory structure
project/lib/gitClasses/ClassName/for class installations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pages/upload.php | Adds class upload functionality with repository selection and tab navigation |
| pages/overview.php | Creates new overview dashboard with class management documentation |
| pages/classes.php | Minor fix to action button variable name consistency |
| package.yml | Adds overview page to navigation structure |
| lib/UpdateManager.php | Standardizes class installation path to gitClasses subdirectory |
| lib/RepositoryManager.php | Updates class status checking for new directory structure |
| lib/NewInstallManager.php | Standardizes class installation path to gitClasses subdirectory |
| lib/GitHubApi.php | Adds uploadFile alias method for consistency |
| lib/ClassManager.php | New comprehensive class management system |
| lang/en_gb.lang | Adds English translations for class management features |
| lang/de_de.lang | Adds German translations for class management features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } else { | ||
| try { | ||
| if (!isset($repositories[$targetRepo])) { | ||
| throw new Exception('Repository nicht gefunden'); |
There was a problem hiding this comment.
Hard-coded German error message should use internationalization. Consider using $addon->i18n('repository_not_found') to maintain consistency with the rest of the codebase.
| } else { | ||
| try { | ||
| if (!isset($repositories[$targetRepo])) { | ||
| throw new Exception('Repository nicht gefunden'); |
There was a problem hiding this comment.
Hard-coded German error message should use internationalization. Consider using $addon->i18n('repository_not_found') to maintain consistency with the rest of the codebase.
Suggested change
| throw new Exception('Repository nicht gefunden'); | |
| throw new Exception($addon->i18n('repository_not_found')); |
| updateClassHandler($(this)); | ||
| }); | ||
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] Extra empty line should be removed to improve code readability.
Suggested change
Comment on lines
+147
to
+151
|
|
||
|
|
||
| /** | ||
| * Alle lokalen Klassen abrufen | ||
| */ |
There was a problem hiding this comment.
[nitpick] Extra empty lines should be removed to improve code consistency.
Suggested change
| /** | |
| * Alle lokalen Klassen abrufen | |
| */ | |
| /** | |
| * Alle lokalen Klassen abrufen | |
| */ | |
| */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.